feat: Proposal to add scope to Maven artifacts for Kafka Connect build #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal to add scope to Maven artifacts for Kafka Connect build Signed-off-by: neeraj-laad <[email protected]>
|
Looks good to me - thanks @neeraj-laad |
scholzj
reviewed
Sep 28, 2025
117-add-scope-parameters-to-maven-artifact-for-kafka-connect-build.md
Outdated
Show resolved
Hide resolved
scholzj
requested review from
Frawless,
PaulRMellor,
im-konge,
katheris,
ppatierno,
samuel-hawker,
see-quick,
sknot-rh and
tombentley
ppatierno
reviewed
Oct 2, 2025
117-add-scope-parameters-to-maven-artifact-for-kafka-connect-build.md
Outdated
Show resolved
Hide resolved
117-add-scope-parameters-to-maven-artifact-for-kafka-connect-build.md
Outdated
Show resolved
Hide resolved
update name based on community feedback Signed-off-by: neeraj-laad <[email protected]>
katheris
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
I'm happy with this proposal, thanks @neeraj-laad
+1 binding
im-konge
approved these changes
Oct 2, 2025
scholzj
approved these changes
Oct 2, 2025
|
This proposal has now 4 (binding) +1. If there are no additional comments by the end of tomorrow, I am going to approve and merge it. |
PaulRMellor
approved these changes
Oct 7, 2025
|
@neeraj-laad this proposal is now approved with 6 +1 binding and 1 +1 non binding votes. |
Renamed files to align proposal numbering and updated README Signed-off-by: neeraj-laad <[email protected]>
Signed-off-by: Neeraj Laad <[email protected]>
|
Thanks @ppatierno I've renamed the file and updated the README |
ppatierno
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to add scope to Maven artifacts for Kafka Connect build
Signed-off-by: neeraj-laad [email protected]