-
Notifications
You must be signed in to change notification settings - Fork 71
Deprecate and remove the .spec.kafka.resources
from the Kafka
CR
#182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Deprecate and remove the .spec.kafka.resources
from the Kafka
CR
#182
Conversation
Signed-off-by: Jakub Scholz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with taking the second option of failing the conversion as stated in the proposal. LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with this change. Thanks @scholzj ! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one nit.
Signed-off-by: Jakub Scholz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This change makes sense and as part of the v1 work.
Few minor suggestions
Co-authored-by: PaulRMellor <[email protected]> Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
This proposal suggests deprecating the
.spec.kafka.resources
field of theKafka
custom resource and removing it in thev1
CRD API.