Skip to content

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Oct 3, 2025

This proposal suggests deprecating the .spec.kafka.resources field of the Kafka custom resource and removing it in the v1 CRD API.

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with taking the second option of failing the conversion as stated in the proposal. LGTM, thanks.

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this change. Thanks @scholzj ! 👍

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one nit.

Signed-off-by: Jakub Scholz <[email protected]>
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
This change makes sense and as part of the v1 work.
Few minor suggestions

scholzj and others added 2 commits October 6, 2025 16:15
Co-authored-by: PaulRMellor <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants