-
Notifications
You must be signed in to change notification settings - Fork 0
45 only run the unit tests which touch changed code in the CI #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
45 only run the unit tests which touch changed code in the CI #50
Conversation
|
It seems like the |
…'t mixing unit tests with model tests and so on
|
Seems like testmon might be problematic for MPI tests https://github.com/struphy-hub/struphy/actions/runs/18819880612/job/53694176303 |
| from psydac.linalg.solvers import inverse | ||
|
|
||
| from struphy.linear_algebra.tests.test_saddlepoint_massmatrices import _plot_residual_norms | ||
| from struphy.tests.unit.linear_algebra.test_saddlepoint_massmatrices import _plot_residual_norms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it a bit odd to import a plotting function from a testing file, should it not be the opposite way around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i agree, please correct.
We can remove the |
If this problem persists, we can try to shorten the mpi unit tests (using |
This could be an option, but I think I can resolve it by only using |
…ged-code-in-the-ci
|
Moved to #96 |
Solves the following issue(s):
Closes #45
Core changes:
None
Model-specific changes:
None
Documentation changes:
None