Skip to content

Conversation

tb-team-dev-2
Copy link

@tb-team-dev-2 tb-team-dev-2 commented Sep 3, 2025

Notes:

  • I made third_party/bittensor-drand a git submodule so that it's more robust to changes. Right now, the git submodule points to my own fork at https://github.com/tb-team-dev-2/bittensor-drand but this should prob be changed to a subtrahend-labs/bittensor-drand fork that would just sync whenever opentensor/bittensor-drand is changed. This can be done with: git submodule set-url third_party/bittensor-drand https://github.com/subtrahend-labs/bittensor-drand. If the git submodule is not wanted, I can always remove it and then we could just manually copy whenever there are changes to opentensor/bittensor-drand
  • The bindings.h file just needed a small update in the generate commit function to handle an extra hotkey arg, then tests started passing
  • On first pull, you will need to run git submodule update --init --recursive to setup the git submodule

Todo:

  • fix merge conflicts with master
  • docs for setup (build with cargo build --release --no-default-features)
  • use commit_timelocked_weightsextrinsic instead of commit_crv3_weights extrinsic
  • make sure logic matches: Add new CRv4 logic opentensor/bittensor#2999

@tb-team-dev-2 tb-team-dev-2 changed the title Continuation of @0xcacti 's feat/crv3 branch to account for crv4 changes WIP: Continuation of @0xcacti 's feat/crv3 branch to account for crv4 changes Sep 3, 2025
@0ximjosh
Copy link
Collaborator

0ximjosh commented Sep 3, 2025

This is great! To avoid merge conflicts i think it might be best to just manually pull over the code to a new branch based on main since there is only a few hundred lines changed.

LMK if you want to tackle that, as id love to get your name in the contributors list. Once its in a new branch based off latest main ill take a look and we can get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants