Skip to content

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Oct 10, 2025

Purpose

We recently upgraded to Eslint v9, it seems that
it is missing some rules that we had previously.
We add them back:

  • @typescript-eslint/no-inferrable-types
  • @typescript-eslint/no-floating-promises

@AntoLC AntoLC self-assigned this Oct 10, 2025
@AntoLC AntoLC added javascript Pull requests that update Javascript code frontend labels Oct 10, 2025
@AntoLC AntoLC requested a review from Ovgodd October 10, 2025 07:52
Copy link

github-actions bot commented Oct 10, 2025

Size Change: +5 B (0%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/853e9b56/_buildManifest.js 0 B -882 B (removed) 🏆
apps/impress/out/_next/static/18524c4b/_buildManifest.js 882 B +882 B (new file) 🆕

compressed-size-action

Copy link
Collaborator

@Ovgodd Ovgodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it !

We recently upgraded to Eslint v9, it seems that
it is missing some rules that we had previously.
We add them back:
- @typescript-eslint/no-inferrable-types
- @typescript-eslint/no-floating-promises
@AntoLC AntoLC merged commit b3cc2bf into main Oct 20, 2025
20 of 22 checks passed
@AntoLC AntoLC deleted the linter/add-rules branch October 20, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants