Repository navigation
Add missing OMOP tables to the default config - #1310
Open
kojikojikojikoji wants to merge 1 commit into
Open
kojikojikojikoji wants to merge 1 commit into
kojikojikojikoji wants to merge 1 commit into
Conversation
observation and device_exposure are listed in the OMOPDataset docstring but were not in omop.yaml, so loading them failed with "Table ... not found in config". Also add observation_period and visit_detail. Columns are the ones shared by CDM v5.3 and v5.4. Signed-off-by: Koji Miyazawa <24467062+kojikojikojikoji@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1294.
The default OMOP config did not define
observation_period,visit_detail,observationordevice_exposure, so loading them raisedTable ... not found in config, though the docstring lists the last two. I used columns that exist in both CDM v5.3 and v5.4.Added small CSVs to
test-resources/omopand a test intests/core/test_omop.pythat loads all four.