Skip to content

feat(branding): Add new logo and update docs #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2025

Conversation

iambriccardo
Copy link
Contributor

@iambriccardo iambriccardo commented Aug 13, 2025

This PR adds a new temporary ETL logo for brand recognition. In addition, it adds our brand colors to MKDOCS and updates the README.

@iambriccardo iambriccardo changed the title riccardobusetti/feat/new logo feat(branding): Add new logo and update docs Aug 13, 2025
@iambriccardo iambriccardo marked this pull request as ready for review August 13, 2025 12:50
@iambriccardo iambriccardo requested a review from a team as a code owner August 13, 2025 12:50
Copy link
Contributor

@imor imor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has made the following undesirable changes to the docs:

  • The next and previous links at the bottom of the page are missing.
  • The table of contents at the right side of a page is missing.
  • The light/dark theme picker next to the search bar is missing.

The above match the wrappers https://fdw.dev/ docs and should be brought back.

Also a few pages were orphaned from the navigation which should be added back:

INFO    -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
             - design/index.md
             - design/etl-crate-design.md
             - guides/index.md
             - guides/database-setup.md
             - reference/index.md
             - tutorials/getting-started.md

The reference section was also removed which we'd need. The docs are roughly modelled as explained here: https://diataxis.fr/

@iambriccardo iambriccardo requested a review from imor August 14, 2025 06:43
Copy link
Contributor

@imor imor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock.

@iambriccardo iambriccardo merged commit 0176c3c into main Aug 14, 2025
6 of 8 checks passed
@iambriccardo iambriccardo deleted the riccardobusetti/feat/new-logo branch August 14, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants