Skip to content

Update nixpkgs #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Update nixpkgs #1714

wants to merge 17 commits into from

Conversation

jfroche
Copy link
Collaborator

@jfroche jfroche commented Jul 21, 2025

Use one recent version of nixpkgs in the flake inputs.

a76c4553d7e741e17f289224eda135423de0491d -> 9807714d6944a957c2e036f84b0ff8caf9930bc0

jfroche and others added 15 commits July 22, 2025 00:05
These overlay packages will be removed once the extensions are updated
to use the new `buildPgrxExtension` function.
trace: evaluation warning: packer-1.13.1 was overridden with `version` but not `src` at /nix/store/y2ddpvhfvv5pshcrj0jckgz36fm9n3c6-source/nix/devShells.nix:49:17.

This is most likely not what you want. In order to properly change the version of a package, override
both the `version` and `src` attributes:

hello.overrideAttrs (oldAttrs: rec {
  version = "1.0.0";
  src = pkgs.fetchurl {
    url = "mirror://gnu/hello/hello-${version}.tar.gz";
    hash = "...";
  };
})

(To silence this warning, set `__intentionallyOverridingVersion = true` in your `overrideAttrs` call.)
The previously used version was failing to build:

/build/source/src/common/get_check_data.c: In function 'pgr_SPI_getText':
/build/source/src/common/get_check_data.c:307:28: error: passing argument 1 of 'DatumGetCString' makes integer from pointer without a cast [-Wint-conversion]
  307 |     return DatumGetCString(SPI_getvalue(*tuple, *tupdesc, info.colNumber));
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                            |
      |                            char *
In file included from /build/source/include/c_common/postgres_connection.h:29,
                 from /build/source/src/common/get_check_data.c:27:
/nix/store/nn6vpjqlsxxmynwcrsib9agb3hpr5cqj-postgresql-17.4/include/server/postgres.h:335:23: note: expected 'Datum' {aka 'long unsigned int'} but argument is of type 'char *'
  335 | DatumGetCString(Datum X)
      |                 ~~~~~~^
make[2]: *** [src/common/CMakeFiles/common.dir/build.make:149: src/common/CMakeFiles/common.dir/get_check_data.c.o] Error 1
We cannot use nodejs.libv8 as it is too new for plv8 3.1.
We will be able to use it with plv8 3.2.
Backport upstream commit to remove the deprecated darwin framework: NixOS/nixpkgs#398707
dbmate 2.27 is now using a varchar for the version column in the
schema_migrations table.

See amacneil/dbmate#641
@jfroche jfroche marked this pull request as ready for review July 22, 2025 13:39
@jfroche jfroche requested review from a team as code owners July 22, 2025 13:39
@samrose samrose self-requested a review July 23, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants