fix(nix): use nixpkgs pgbackrest instead of a from-source build - #2267
Draft
hunleyd wants to merge 1 commit into
Draft
fix(nix): use nixpkgs pgbackrest instead of a from-source build#2267hunleyd wants to merge 1 commit into
hunleyd wants to merge 1 commit into
Conversation
PostgreSQL Extension Dependency Analysis: PR #2267
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2267
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
hunleyd
marked this pull request as ready for review
July 12, 2026 23:45
brainrake
requested changes
Jul 13, 2026
Collaborator
There was a problem hiding this comment.
https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/pg/pgbackrest/package.nix
- Latest pgbackrest 2.58.0 is in nixpkgs. Use this please.
- If not good and need eg. different build options, lease override nixpkgs package instead of copying it verbatim, unless there is a blocker. Lower maintenance burden.
- Add pgbackrest src repo as a non-flake input to the flake. This way hashes are managed using default tools in the lockfile instead of manually.
Collaborator
|
If we need to update nixpkgs, lets prioritize that, it needs to be done in any case. Doing the chores is preferable to deep special casing. Special casing will only make it more difficult to stay up to date, which we need to do anyway to bring in stack wide security updates. |
hunleyd
changed the title
hunleyd
changed the title
hunleyd
enabled auto-merge
July 13, 2026 16:47
hunleyd
marked this pull request as draft
July 13, 2026 17:05
auto-merge was automatically disabled
July 13, 2026 17:05
Pull request was converted to draft
Contributor
Author
This comment has been minimized.
This comment has been minimized.
hunleyd
marked this pull request as ready for review
August 25, 2026 16:45
hunleyd
enabled auto-merge
August 25, 2026 16:45
hunleyd
disabled auto-merge
August 25, 2026 16:52
hunleyd
marked this pull request as draft
August 25, 2026 16:52
Contributor
Author
|
@claude review |
hunleyd
marked this pull request as ready for review
September 1, 2026 18:10
hunleyd
marked this pull request as draft
September 1, 2026 18:11
Adds pg-backrest to the Linux-only CI build-check list in nix/checks.nix, so a break in the pgbackrest flake output is caught at CI time instead of first surfacing during an AMI build. The pg-backrest package itself (nix/packages/default.nix, a plain passthrough of nixpkgs.legacyPackages.<system>.pgbackrest) already landed on develop independently via #1714; this PR only adds the CI check for it. This PR originally added a from-source meson build of pgbackrest (nix/packages/pgbackrest.nix) to pin an exact version and mesonFlags; that was reverted in favor of the nixpkgs passthrough, so no from-source recipe remains. Version consistency across a cluster is handled independently of pgbackrest's own version pin: ansible/tasks/setup-pgbackrest.yml installs via `nix profile install github:supabase/postgres/{{ git_commit_sha }}#pg-backrest`, locked to the exact postgres repo commit. Dockerfile-multigres consumes the same flake output by name.
hunleyd
force-pushed
the
douglashunley/indata-520-create-a-supabase-nix-pkg-for-pgbackrest
branch
from
September 3, 2026 21:53
b73b6c0 to
14922e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
pg-backrestto the Linux-only CI build-check list innix/checks.nix, so a break in the pgbackrest flake output is caught at CI time instead of first surfacing during an AMI build. Thepg-backrestpackage itself already landed ondevelopindependently via #1714; this PR only adds the CI check for it.(bot-generated information collapsed below)
Details
pg-backrestpackage itself (nix/packages/default.nix, a plain passthrough ofnixpkgs.legacyPackages.<system>.pgbackrest) already landed ondevelopindependently via Update nixpkgs #1714. This PR does not change it.nix/packages/pgbackrest.nix) to pin an exact version and mesonFlags; that was reverted in favor of the nixpkgs passthrough, so no from-source recipe remains.ansible/tasks/setup-pgbackrest.ymlinstalls vianix profile install github:supabase/postgres/{{ git_commit_sha }}#pg-backrest, locked to the exact postgres repo commit.Dockerfile-multigresconsumes the same flake output by name.flake.lockupdate automation that ci: fix update-flake-lock workflow (app token + update-flake-lock action) #2281 (PSQL-1388) is fixing, and is tracked separately in MUL-129; informational only, not a merge blocker for this PR, since this diff makes noflake.lockchange.nix-eval / evalis a required check that evaluates thechecksoutput this PR addspg-backrestto. If a future nixpkgs bump ever breaks pgbackrest at eval time (not just build time), that shows up asnix-evalgoing red on an unrelated PR. This repo has hit that failure mode once already (seec261fda8, this branch's own revert of a nixpkgs bump for the same reason).Testing
nix build .#pg-backrestsucceedsnix build .#checks.<linux-system>.pg-backrestsucceedsMisc
Resolves INDATA-520, using the plain nixpkgs passthrough rather than a from-source build.