added three new algos #5
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
This PR adds three C++ implementations for LeetCode problems: longest substring without repeating chars, merge intervals, and peak element. However, there are critical issues: missing #include in the first file, incorrect merging logic in the second, and array index out-of-bounds in the third. These need fixing before the code can be approved.
| seen.erase(s[left++]); | ||
| } | ||
| seen.insert(s[right]); | ||
| maxLen = max(maxLen, right - left); |
There was a problem hiding this comment.
std::max is used without including . Add ' #include ' to this file.
| sort(intervals.begin(), intervals.end()); | ||
| vector<vector<int>> merged; | ||
| for (auto interval : intervals) { | ||
| if (merged.empty() || merged.back()[1] < interval[1]) { |
There was a problem hiding this comment.
This condition incorrectly handles interval merging; it should check if interval[0] <= merged.back()[1] to decide merging.
| int left = 0, right = nums.size(); | ||
| while (left < right) { | ||
| int mid = left + (right - left) / 2; | ||
| if (nums[mid] > nums[mid + 1]) |
There was a problem hiding this comment.
Accessing nums[mid+1] may cause out-of-bounds if mid = nums.size() - 1. Revise the binary search to avoid undefined behavior.
2 participants
No description provided.