Skip to content

[SEL3-41] Documenting ironic known issue for network device naming #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Gagrio
Copy link
Contributor

@Gagrio Gagrio commented Jul 22, 2025

@Gagrio
Copy link
Contributor Author

Gagrio commented Jul 22, 2025

@hardys @e-minguez could you please advise on wording, anything missing, backporting etc? I am sure this is not optimal as it was done a bit in a hurry and I am not the best with words, but it's much easier to amend this to something better than not having anything in place. Thanks!

@Gagrio Gagrio requested a review from hardys July 22, 2025 14:26
Copy link
Collaborator

@e-minguez e-minguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using the UUIDs is a bit fragile. I'm not 100% sure how nmc generates those and if it changes between versions. The most robust approach is to use the proper device names. /cc @atanasdinov to double check if relying on the uuid generation is safe or not.

@@ -33,3 +33,5 @@ automated inspection, cleaning and provisioning/deprovisioning.
* The upstream https://github.com/metal3-io/ip-address-manager[IP Address Management controller] is currently not supported, because it is not yet compatible with our choice of network configuration tooling.
* Relatedly, the IPAM resources and Metal3DataTemplate networkData fields are not supported.
* Only deployment via redfish-virtualmedia is currently supported.
* It is possible to observe a network device name missalignment between the ironic python agent (IPA) and the target operating system (SLE Micro 6.0/6.1), especially when trying to configure predictable names for the devices.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* It is possible to observe a network device name missalignment between the ironic python agent (IPA) and the target operating system (SLE Micro 6.0/6.1), especially when trying to configure predictable names for the devices.
* It is possible to observe a network device name misalignment between the ironic python agent (IPA) and the target operating system (SL Micro 6.0/6.1), especially when trying to configure predictable names for the devices.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Using device names is also not straightforward as those are not known in advance so the customers would still need to fail, record device names and try again. Also it's not allowing automation since each server might have different device naming

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it is not ideal but I feel it is more robust than relying on the uuid being generated by nmc. I guess we should perhaps document both options?
/cc @hardys for his inputs.

@Gagrio Gagrio requested a review from e-minguez July 24, 2025 14:11
@e-minguez
Copy link
Collaborator

Just in case, it seems it is not that fragile but based on the interface name and interface type https://github.com/nmstate/nmstate/blob/e05e1f25fd72808d55b837346b489b4669eb823c/rust/src/lib/nm/settings/connection.rs#L430-L440

Copy link
Collaborator

@e-minguez e-minguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestion to specify the two options currently available.

@Gagrio Gagrio requested a review from e-minguez July 24, 2025 15:53
Copy link
Collaborator

@e-minguez e-minguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for @hardys feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants