Skip to content

Conversation

Gagrio
Copy link
Contributor

@Gagrio Gagrio commented Jul 22, 2025

@Gagrio
Copy link
Contributor Author

Gagrio commented Jul 22, 2025

@hardys @e-minguez could you please advise on wording, anything missing, backporting etc? I am sure this is not optimal as it was done a bit in a hurry and I am not the best with words, but it's much easier to amend this to something better than not having anything in place. Thanks!

@Gagrio Gagrio requested a review from hardys July 22, 2025 14:26
Copy link
Collaborator

@e-minguez e-minguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using the UUIDs is a bit fragile. I'm not 100% sure how nmc generates those and if it changes between versions. The most robust approach is to use the proper device names. /cc @atanasdinov to double check if relying on the uuid generation is safe or not.

@Gagrio Gagrio requested a review from e-minguez July 24, 2025 14:11
@e-minguez
Copy link
Collaborator

Just in case, it seems it is not that fragile but based on the interface name and interface type https://github.com/nmstate/nmstate/blob/e05e1f25fd72808d55b837346b489b4669eb823c/rust/src/lib/nm/settings/connection.rs#L430-L440

Copy link
Collaborator

@e-minguez e-minguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestion to specify the two options currently available.

@Gagrio Gagrio requested a review from e-minguez July 24, 2025 15:53
Copy link
Collaborator

@e-minguez e-minguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for @hardys feedback. Thanks!

e-minguez
e-minguez previously approved these changes Aug 7, 2025
@hardys
Copy link
Contributor

hardys commented Aug 21, 2025

Sorry for the slow reply - overall this looks good to me, just one suggestion re the tips section to make it a bit clearer

@hardys hardys merged commit 66c32aa into suse-edge:main Aug 28, 2025
1 check passed
Gagrio added a commit to Gagrio/suse-edge.github.io that referenced this pull request Aug 29, 2025
…use-edge#762)

* SEL3-41 Documenting ironic known issue for network device naming

* SEL3-41 rewording, fixes and adding an example with two secrets for network configuration

* Updating wording

* reordering things in the tips document
Gagrio added a commit to Gagrio/suse-edge.github.io that referenced this pull request Aug 29, 2025
…use-edge#762)

* SEL3-41 Documenting ironic known issue for network device naming

* SEL3-41 rewording, fixes and adding an example with two secrets for network configuration

* Updating wording

* reordering things in the tips document
hardys pushed a commit that referenced this pull request Sep 1, 2025
)

* SEL3-41 Documenting ironic known issue for network device naming

* SEL3-41 rewording, fixes and adding an example with two secrets for network configuration

* Updating wording

* reordering things in the tips document
hardys pushed a commit that referenced this pull request Sep 1, 2025
)

* SEL3-41 Documenting ironic known issue for network device naming

* SEL3-41 rewording, fixes and adding an example with two secrets for network configuration

* Updating wording

* reordering things in the tips document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants