-
Notifications
You must be signed in to change notification settings - Fork 37
[SEL3-41] Documenting ironic known issue for network device naming #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hardys @e-minguez could you please advise on wording, anything missing, backporting etc? I am sure this is not optimal as it was done a bit in a hurry and I am not the best with words, but it's much easier to amend this to something better than not having anything in place. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using the UUIDs is a bit fragile. I'm not 100% sure how nmc generates those and if it changes between versions. The most robust approach is to use the proper device names. /cc @atanasdinov to double check if relying on the uuid generation is safe or not.
…etwork configuration
Just in case, it seems it is not that fragile but based on the interface name and interface type https://github.com/nmstate/nmstate/blob/e05e1f25fd72808d55b837346b489b4669eb823c/rust/src/lib/nm/settings/connection.rs#L430-L440 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added suggestion to specify the two options currently available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's wait for @hardys feedback. Thanks!
Sorry for the slow reply - overall this looks good to me, just one suggestion re the tips section to make it a bit clearer |
…use-edge#762) * SEL3-41 Documenting ironic known issue for network device naming * SEL3-41 rewording, fixes and adding an example with two secrets for network configuration * Updating wording * reordering things in the tips document
…use-edge#762) * SEL3-41 Documenting ironic known issue for network device naming * SEL3-41 rewording, fixes and adding an example with two secrets for network configuration * Updating wording * reordering things in the tips document
https://jira.suse.com/projects/SEL3/issues/SEL3-41?filter=allopenissues