Adds a title to each of the port-requirements tables, clarifying these are Ingress ports #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-minguez
previously approved these changes
Sep 1, 2025
ranjinimn
reviewed
Sep 1, 2025
| @@ -78,6 +78,7 @@ The following table lists the opened ports in nodes running the management clust | |||
| For CNI plug-in related ports, see <<cni-specific-port-requirements,CNI specific port requirements>>. | |||
| ==== | |||
|
|
|||
| .Inbound Network Rules for Management Nodes | |||
| |=== | |||
| | Protocol | Port | Source | Description | |||
There was a problem hiding this comment.
Leaving a space between the line 84 and line 85 will make the headers bold.
Suggested change
| | Protocol | Port | Source | Description | |
| |=== | |
| | Protocol | Port | Source | Description | |
| | TCP | |
| | 22 | |
| | Any source that requires SSH access | |
| | SSH access to management cluster nodes |
There was a problem hiding this comment.
Doing as such, thanks ;-)
ranjinimn
reviewed
Sep 1, 2025
ranjinimn
reviewed
Sep 1, 2025
| @@ -78,6 +78,7 @@ The following table lists the opened ports in nodes running the management clust | |||
| For CNI plug-in related ports, see <<cni-specific-port-requirements,CNI specific port requirements>>. | |||
| ==== | |||
|
|
|||
There was a problem hiding this comment.
To provide an identifier to the table:
[#file-name-table-first]
There was a problem hiding this comment.
Where exactly should I add this [#file-name-table-first] asciidoc directive?
There was a problem hiding this comment.
Suggested change
| .Inbound Network Rules for Management Nodes | |
| [#table-inbound-network-rules-for-management-nodes] |
ranjinimn
previously approved these changes
Sep 2, 2025
| @@ -29,6 +29,7 @@ The hardware requirements for SUSE Telco Cloud are as follows: | |||
|
|
|||
There was a problem hiding this comment.
To align the table, please add "+" here.
Suggested change
| + |
… are Ingress ports Signed-off-by: Antonio Alonso Alarcon <[email protected]>
ranjinimn
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #814
This PR adds a title to each of the tables listed in
Port requirementssection (inasciidoc/product/atip-requirements.adocfile) where it is clarified the listed ports are all Ingress ports.