Add MetalLB BGP documentation #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alknopfler
reviewed
Sep 8, 2025
alknopfler
previously approved these changes
Sep 8, 2025
|
I hope I addressed all comments |
hardys
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
LGTM - couple of small comments:
- I adjusted the title, IMO it's best to use a descriptive title and for draft PRs use "Convert to Draft" (so the PR can't be accidentally merged, and so we have a descriptive title for the commit message if we squash-merge)
- I agree with Alberto that we may want to revisit the structure in future - for now this is fine, but perhaps we should in future consider moving some/all of this content under the SUSE Telco Cloud section?
- We need to reach a conclusion re the support status, if it's TP we should indicate this in the new docs (and release notes when we prepare them)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation for MetalLB in BGP mode.