Skip to content

Conversation

roni-frantchi
Copy link

Added an option to skip ECS Service creation.
It is helpful for cases where one wishes to run the generated task definition in the generated cluster using AWS API instead of having a long running service.

Copy link

@dazza-codes dazza-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.
Is there any way we could get that merged in? It would be really useful for some use cases, and doesn't change the default behavior of the add-on.
Thanks!

Copy link

@BenCoffeed BenCoffeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bdo
Copy link

bdo commented Jan 25, 2022

@svdgraaf Would it be possible for you to merge this in please?

And happy to create another version of this PR if you think it is not ready for prime time. Tell me what needs updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants