Fix for #4904 - Invalid cast of JsonSchema to ComposedSchema #4948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djankows Could you look at this, please? |
EmhyrVarEmreis
force-pushed
the
master
branch
2 times, most recently
from
a9a2aa2 to
e40161a
Compare
davsclaus
approved these changes
Aug 1, 2025
|
@EmhyrVarEmreis thank you for finding the fix for the issue. Based on your PR I have created fix: Fix ClassCastException on resolving JsonSchema. This solves issu… by ewaostrowska · Pull Request #4950 · swagger-api/swagger-core with some additional tests to make sure that the fix won't cause any regression. I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves issue #4904. After introduction of JsonSchema the composed schema part stopped working.
Fixes: #4904
Type of Change
Checklist