Add getOrThrow() helper to Option and Result #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylvln
force-pushed
the
feat/get-or-throw
branch
from
64217a7 to
393781a
Compare
jeremylvln
force-pushed
the
feat/get-or-throw
branch
from
393781a to
e60c26b
Compare
bloodyowl
reviewed
Jul 25, 2025
| */ | ||
| getOrThrow(this: Result<A, E>): A | never { | ||
| if (this.tag === "Error") { | ||
| throw new Error("Tried to unwrap a Result.Error value"); |
There was a problem hiding this comment.
I'd throw this.error directly in this case, or at least put it in the error's cause.
There was a problem hiding this comment.
Nice idea, I wanted to use cause, unfortunately it is not supported yet by the Typescript version used in the project.
Now throwing this.error if the error is string. Also added the implementation for AsyncData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Some of my tests needs to prepare some context by calling methods returning
Results. These methods are already well-tested, I do not want to bother to check again forOkorError. Having these shortcut helpers would help me simplify the tests.Pretty similar to Rust's
unwrap()methods.