-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor(plugin/runner): Switch wasmtime-wasi
to wasi-common
#10979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a0b1fa3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
CodSpeed Performance ReportMerging #10979 will not alter performanceComparing Summary
|
wasmtime-wasi
to wasi-common
Description:
Currently,
wasmtime-wasi
uses tokioblock_on
internally, which causes panic when used in the tokio runtime.I originally thought this could be solved by use
block_in_place
, but the large scope ofblock_in_place
caused a serious performance regression (even without use plugin). see web-infra-dev/rspack#11303 (comment)Switch to
wasi-common
is a better choice, which simplifies the wasi implment and makes it independent of tokio.BREAKING CHANGE:
Related issue (if exists):