Skip to content

Conversation

quininer
Copy link
Contributor

@quininer quininer commented Aug 6, 2025

Description:

Currently, wasmtime-wasi uses tokio block_on internally, which causes panic when used in the tokio runtime.

I originally thought this could be solved by use block_in_place, but the large scope of block_in_place caused a serious performance regression (even without use plugin). see web-infra-dev/rspack#11303 (comment)

Switch to wasi-common is a better choice, which simplifies the wasi implment and makes it independent of tokio.

BREAKING CHANGE:

Related issue (if exists):

@quininer quininer requested a review from a team as a code owner August 6, 2025 11:07
Copy link

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: a0b1fa3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Aug 6, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcopyfiles@​2.4.110010010076100
Addedwebpack-cli@​3.3.129710010082100
Addedwebpack-dev-server@​3.11.3969210084100
Addedwebpack@​4.47.09710010096100

View full report

Copy link

socket-security bot commented Aug 6, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
[email protected] has a Critical CVE.

CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL)

Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4

Patched version: 2.5.4

From: ?npm/[email protected]

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link

codspeed-hq bot commented Aug 6, 2025

CodSpeed Performance Report

Merging #10979 will not alter performance

Comparing quininer:x/fix-wasi (a0b1fa3) with main (a10dada)

Summary

✅ 140 untouched benchmarks

@kdy1 kdy1 added this to the Planned milestone Aug 6, 2025
@kdy1 kdy1 changed the title refactor(plugin/runner): Switch wasmtime-wasi to wasi-common refactor(plugin/runner): Switch wasmtime-wasi to wasi-common Aug 6, 2025
@kdy1 kdy1 merged commit c4114d5 into swc-project:main Aug 6, 2025
35 checks passed
@quininer quininer deleted the x/fix-wasi branch August 6, 2025 12:38
@kdy1 kdy1 modified the milestones: Planned, 1.13.4 Aug 21, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants