-
Notifications
You must be signed in to change notification settings - Fork 96
Remove deprecated ubuntu-20.04 runners [OI-3101] #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -14,30 +14,11 @@ on: | |||
jobs: | |||
tests-java-1_8: | |||
name: Test | |||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated runner
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: gradle/gradle-build-action@v3 | ||
with: | ||
gradle-version: 7.1.1 | ||
- name: Run tests | ||
run: make test-java | ||
|
||
# sonarqube: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to comment out, saved in git history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗑️
@@ -14,30 +14,21 @@ on: | |||
jobs: | |||
tests-java-1_8: | |||
name: Test | |||
runs-on: ubuntu-20.04 | |||
runs-on: ubuntu-24.04 | |||
container: ubuntu:20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These java tests require an old java version, so we still run ubuntu 20.04 in a container
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @armallen.
Can we merge this in? @armallen |
Description
While working on #1487 I noticed several pipelines pipelines are failing/timing out (example: https://github.com/swift-nav/libsbp/actions/runs/16514255607/job/46702019004).
These are relying on deprecated github actions runners (ubuntu-20.04), which are not available anymore. This PR removes as much ubuntu-20.04 references as possible.
With this PR, all existing libsbp CI workflows are functional 🎉
API compatibility
No API change
Related PRs
Implemented while working on #1487