Skip to content

Provide Bazel 8 compatibility #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2025

Conversation

martin4861
Copy link
Contributor

@martin4861 martin4861 commented Aug 4, 2025

In order to use Bazel 8 following changes are needed:

  • empty globs are marked allow_empty
  • + instead of ~ as bzl_mod path seperator (backwards compatibility to Bazel 7 can be achieved using --incompatible_use_plus_in_repo_names)

Tested in

  • starling-core (Bazel 6)
  • starling-core (Bazel 7)
  • starling-core (Bazel 8)

@martin4861 martin4861 marked this pull request as ready for review August 4, 2025 10:41
@martin4861 martin4861 requested a review from a team as a code owner August 4, 2025 10:41
@martin4861 martin4861 marked this pull request as draft August 4, 2025 10:42
@martin4861 martin4861 force-pushed the martin4861/provide-bazel-8-compatibility branch from 528fe24 to 3701462 Compare August 4, 2025 10:42
@martin4861 martin4861 marked this pull request as ready for review August 4, 2025 10:55
@martin4861 martin4861 merged commit dc9d99f into main Aug 4, 2025
1 check passed
@martin4861 martin4861 deleted the martin4861/provide-bazel-8-compatibility branch August 4, 2025 12:11
@martin4861 martin4861 mentioned this pull request Aug 5, 2025
3 tasks
martin4861 added a commit that referenced this pull request Aug 6, 2025
Follow up on #169

In order to use Bazel 8 following changes are needed:
* select proper `sysroot`s for some additional toolchains
* `+` instead of `~` as `bzl_mod` path seperator (backwards
compatibility to Bazel 7 can be achieved using
`--incompatible_use_plus_in_repo_names`) for some more toolchains

Tested in
- [x] starling-core (Bazel 6)
- [x] starling-core (Bazel 7)
- [x] starling-core (Bazel 8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants