Add standard argument to swift_cc_test_library and swift_c_test
#192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbmueller
changed the title
swift_cc_test_libraryswift_cc_test_library
armallen
reviewed
Sep 25, 2025
|
|
||
| _ = kwargs.pop("nocopts", []) # To handle API compatibility. | ||
|
|
||
| nocopts = kwargs.pop("nocopts", []) # pop because nocopts is a deprecated cc* attr. |
There was a problem hiding this comment.
Had a look at the rest of the file, and it seems swift_c_test might also be missing the standard option? swift_cc_test uses it.
armallen
approved these changes
Sep 25, 2025
sbmueller
changed the title
swift_cc_test_libraryswift_cc_test_library and swift_c_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift_cc_test_libraryandswift_c_testdid not support thestandardattribute, which allows an explicit selection of the language standard. We want to be able to precisely set the C/C++ standard for all targets. All other swift related rules support this already.Reviving @armallen's old commits.