Skip to content

Add swift_c_test_library to cc rules #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2025
Merged

Add swift_c_test_library to cc rules #194

merged 3 commits into from
Oct 2, 2025
+27 −0

Conversation

sbmueller
Copy link
Contributor

We have swift_cc_test_library and swift_c_test, but swift_c_test_library was missing.

@sbmueller sbmueller requested a review from a team as a code owner October 2, 2025 06:51
@sbmueller sbmueller requested a review from jakalm October 2, 2025 06:52
jakalm
jakalm approved these changes Oct 2, 2025
View reviewed changes
Copy link

@jakalm jakalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a documentation comment.

@sbmueller sbmueller merged commit 7f87a8d into main Oct 2, 2025
2 checks passed
@sbmueller sbmueller deleted the smuller/AP-3456-fix-cxxopts branch October 2, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakalm jakalm jakalm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbmueller @jakalm