Skip to content

Conversation

mattcorey
Copy link
Contributor

Instructions for customizing the output path are incorrect

Motivation:

displayHelpMessage was incorrect - it claimed that the output path was customizable via a --output-directory flag, but the code actually looks for --output-path

Modifications:

Changing the help message here, instead of the code, in case existing projects already depend on --output-path

Result:

displayHelpMessage will show the correct instructions

`displayHelpMessage` was incorrect - it claimed that the output path was customizable via a `--output-directory` flag, but the code actually looks for `--output-path`

Changing the help message here, instead of the code, in case existing projects already depend on `--output-path`
@sebsto sebsto self-assigned this Feb 26, 2025
@sebsto sebsto self-requested a review February 26, 2025 22:40
@sebsto sebsto added the semver/none No version bump required. label Feb 26, 2025
Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebsto sebsto merged commit 64b4179 into swift-server:main Feb 26, 2025
31 checks passed
@sebsto
Copy link
Contributor

sebsto commented Feb 26, 2025

Thank you for having spot this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants