[lldb] make check-lldb a disjoint set of check-lldb-swift #11695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Oct 24, 2025
|
@swift-ci please test |
charles-zablit
force-pushed
the
charles-zablit/windows/lldb-only-run-swift-test-subset
branch
from
ee40430 to
c5a6610
Compare
|
@swift-ci please test |
charles-zablit
force-pushed
the
charles-zablit/windows/lldb-only-run-swift-test-subset
branch
from
c5a6610 to
82a5cab
Compare
charles-zablit
changed the title
adrian-prantl
requested changes
Oct 25, 2025
There was a problem hiding this comment.
I don't think this would be a good idea. The check-lldb target is meant to run all LLDB tests. We have other check-lldb-* targets and all of them are subsets of check-lldb, for example check-lldb-api, and check-lldb-shell. If we restricted check-lldb to only run non-swift tests that would break with this convention. That would be very confusing and also break tons of automation.
|
This convention isn't even LLDB-specific, all check-targets in LLVM behave like this (e.g., |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
check-lldba disjoint set ofcheck-lldb-swiftmeaningcheck-lldbruns the same set of tests as upstream.