Skip to content

Implement sourcekit-lsp --version option #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement sourcekit-lsp --version option #1496

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a08838
Implement `sourcekit-lsp --version` option
MaxDesiatov Jun 19, 2024
4c73b8f
Merge branch 'main' into maxd/support-version-option
MaxDesiatov Aug 1, 2024
73be537
Merge branch 'main' into maxd/support-version-option
MaxDesiatov Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Sources/sourcekit-lsp/SourceKitLSP.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
//===----------------------------------------------------------------------===//

import ArgumentParser
import struct Basics.SwiftVersion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not add a dependency on SwiftPM for this. I’ve been trying to isolate SourceKit-LSP’s dependency on SwiftPM recently and would prefer to not add a new one. I still don’t know what the best solution would be. I wrote down some of my thoughts in #1424 (comment).

import Csourcekitd // Not needed here, but fixes debugging...
import Diagnose
import Dispatch
Expand Down Expand Up @@ -103,6 +104,7 @@ extension SKSupport.WorkspaceType: @retroactive ExpressibleByArgument {}
struct SourceKitLSP: AsyncParsableCommand {
static let configuration = CommandConfiguration(
abstract: "Language Server Protocol implementation for Swift and C-based languages",
version: "sourcekit-lsp \(Basics.SwiftVersion.current.displayString)",
subcommands: [
DiagnoseCommand.self,
DebugCommand.self,
Expand Down