Skip to content

Fix visibility on import triggering a compile warning #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix visibility on import triggering a compile warning #2151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sources/SKLogging/CustomLogStringConvertible.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@
//
//===----------------------------------------------------------------------===//

// NSObject is defined in Foundation on non-darwin platforms. On
// darwin, NSObject is package-visible.
#if canImport(ObjectiveC)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick: We usually use #if canImport(Darwin) to conditionally compile code for Darwin vs. non-Darwin platforms. I’d prefer to be consistent with that pattern here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this one and update to Darwin separately 👍

import Foundation
#else
package import Foundation
#endif

#if !NO_CRYPTO_DEPENDENCY
import Crypto
Expand Down