Skip to content

Fix a couple build warnings #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 14, 2025

No description provided.

@ahoppen
Copy link
Member Author

ahoppen commented Jul 14, 2025

@swift-ci Please test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I missed this one - I was just about to put this up. There's another if you want to update this one, or I'll do a separate:

-extension OSSignposter: @retroactive @unchecked Sendable {}
-extension OSSignpostID: @retroactive @unchecked Sendable {}
-extension OSSignpostIntervalState: @retroactive @unchecked Sendable {}

Those are all in since 6.1 (first two in 6.0 and last in 6.1).

@@ -17,7 +17,7 @@ import SwiftSyntax

/// Describes types that provide one or more code actions based on purely
/// syntactic information.
protocol SyntaxCodeActionProvider {
protocol SyntaxCodeActionProvider: SendableMetatype {
Copy link
Contributor

@bnbarham bnbarham Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only available in 6.2. I added a:

+#if compiler(<6.2)
+package typealias SendableMetatype = Any
+#endif

in AsyncUtils.swift in mine.

@ahoppen ahoppen force-pushed the fix-build-warnings branch from 3995215 to 0b3db5e Compare August 4, 2025 10:33
@ahoppen
Copy link
Member Author

ahoppen commented Aug 4, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Aug 4, 2025

@swift-ci Please test Windows

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahoppen
Copy link
Member Author

ahoppen commented Aug 4, 2025

@swift-ci Please test Windows

2 similar comments
@ahoppen
Copy link
Member Author

ahoppen commented Aug 5, 2025

@swift-ci Please test Windows

@ahoppen
Copy link
Member Author

ahoppen commented Aug 7, 2025

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 56a91e9 into swiftlang:main Aug 7, 2025
3 checks passed
@ahoppen ahoppen deleted the fix-build-warnings branch August 7, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants