Skip to content

Fix algorithmic bug causing exponential blowup in dependency analysis #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

Fix algorithmic bug causing exponential blowup in dependency analysis #2218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/BuildSystemIntegration/BuildSystemManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,7 @@ package actor BuildSystemManager: QueueBasedMessageHandler {
dependents[dependency, default: []].insert(target)
// Check if we have already recorded this target with a greater depth, in which case visiting it again will
// not increase its depth or any of its children.
if depths[target, default: 0] < depth + 1 {
if depths[dependency, default: 0] < depth + 1 {
worksList.append((dependency, depth + 1))
}
}
Expand Down