Skip to content

Make Android NDK discovery more robust, and add tests #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jakepetroules
Copy link
Collaborator

Add support for Android NDK versions 23 through 26, and emit an explicit error for older versions. Add test coverage to verify parsing of the metadata.

I chose 23 as the cutoff for now simply because that's the next last time that the abis.json schema changed. That version was released in August 2021. We can add older versions if anyone really wants them.

Add support for Android NDK versions 23 through 26, and emit an explicit error for older versions. Add test coverage to verify parsing of the metadata.

I chose 23 as the cutoff for now simply because that's the next last time that the abis.json schema changed. That version was released in  August 2021. We can add older versions if anyone really wants them.
@jakepetroules jakepetroules marked this pull request as ready for review July 18, 2025 23:15
@jakepetroules
Copy link
Collaborator Author

@swift-ci test

@jakepetroules
Copy link
Collaborator Author

@swift-ci test linux

@jakepetroules jakepetroules added the android Support for the Android platform label Jul 26, 2025
@jakepetroules
Copy link
Collaborator Author

@swift-ci test linux

@jakepetroules jakepetroules changed the base branch from release/6.2 to main July 29, 2025 21:41
@jakepetroules jakepetroules merged commit 47030cc into swiftlang:main Jul 29, 2025
23 of 24 checks passed
@jakepetroules jakepetroules deleted the eng/PR-android-ndk-improvements-release/6.2 branch July 29, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Support for the Android platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants