Add initializer to LinkCompletionTools.SymbolInformation that accepts a SymbolGraph.Symbol
#1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related SourceKit-LSP PR: swiftlang/sourcekit-lsp#2216 |
… a SybolGraph.Symbol
matthewbastien
force-pushed
the
sourcekit-lsp-func-disambiguations
branch
from
b1d0e17 to
ca40173
Compare
|
@swift-ci please test |
d-ronnqvist
approved these changes
Jul 29, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new public initializer to
LinkCompletionTools.SymbolInformationthat will extract the function signature (if any) from aSymbolGraph.Symbol. This will primarily be used by SourceKit-LSP so that it doesn't have to re-implement the logic for constructing parameter and return type disambiguations.Checklist
[ ] Added tests./bin/testscript and it succeeded[ ] Updated documentation if necessaryNo new tests needed: this only exposes existing functionality to SourceKit-LSP.