Remove unused private code from the symbol graph loader #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
QuietMisdreavus
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
This looks fine to remove. I think loadSymbolGraph(at:) may have been a remnant of a time before the UnifiedSymbolGraph was introduced, but i have no idea why availabilityItem(for:) was there. It seems to have been a way to cache a conversion between the Info.plist's availability items and their equivalent SymbolGraph availability items? It would probably take some amount of Git history delving to know why they were there and how they were previously used, but for now i think it's fine to take them out.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This removes a little bit of unused private code in the symbol graph loader.
It's not clear to me if there's some place that's expected to call this code that doesn't.
Dependencies
None.
Testing
Nothing in particular. This isn't a user-facing change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
AddedUpdated tests./bin/testscript and it succeeded[ ] Updated documentation if necessaryn/a