Improve performance of JSONDecoder and JSONEncoder for large apps #1481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short:
T.self is _JSONStringDictionaryDecodableMarker.Type
,value as? _JSONStringDictionaryEncodableMarker
andvalue as? _JSONDirectArrayEncodable
are really slow operations. And the bigger binary gets the slower this check works for the first time for each pair ofclass/struct/enum
and protocol.But checking whether current type conforms to
_JSONStringDictionaryDecodableMarker
and_JSONStringDictionaryEncodableMarker
is needed only when we use custom keyDecoding/EncodingStrategy. Comments in code confirm this:So we can easily skip this checks when default keyDecoding/EncodingStrategy is used.
For details: see this issue: #1480