fix linker flags for dynamic libraries when executing command plugin #9091
Conversation
supersonicbyte
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
ofc! |
|
@owenv added, can you run the CI please? |
|
@swift-ci test |
| @@ -6948,5 +6948,172 @@ struct PackageCommandTests { | |||
| expectNoDiagnostics(observability.diagnostics) | |||
| } | |||
| } | |||
|
|
|||
| @Test(arguments: getBuildData(for: SupportedBuildSystemOnAllPlatforms)) | |||
There was a problem hiding this comment.
It's ok to wrap this in something like this for now to get to a passing CI run:
withKnownIssue {
} when: {
ProcessInfo.hostOperatingSystem == .windows
|| (ProcessInfo.hostOperatingSystem == .linux && data.buildSystem == .swiftbuild)
}
There are some unrelated issues setting up the runtime library paths on linux for plugin executables which I haven't fixed yet.
There was a problem hiding this comment.
@owenv can you rerun the CI again, please?
|
@swift-ci test |
|
Not sure what the proper process is as this affects both Darwin and Linux, but if possible to cherry-pick this for a future 6.2 it would be fantastic as it would unblock the work in progress for ordo-one/package-benchmark#318 - currently there is no way to do that with a plugin without breaking benchmark users CI. |
|
@swift-ci test |
|
@swift-ci test windows |
|
@owenv @plemarquand not sure what's with the windows build? |
Add appropriate
-toolsuffix to linker flags in dynamic libraries when executingswift package command_plugin.Motivation:
Resolves the following issue: #9062
Modifications:
Add appropriate
-toolsuffix to linker flags in dynamic libraries when executingswift package command_plugin.Result:
Executing
swift package command_pluginwith dynamic dependencies works.