[WIP] Fix for required dependencies calculation with traits #9269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enabled traits property was essentially being erased to defaults rather than propagating what was calculated earlier due to how we were returning the DependencyResolutionNode during the pub grub stage. This fix should now assure that we are passing the appropriate enabled traits to these nodes, and are being considered when making calls to PackageContainer's dependency-related methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] TO CLEAN UP
The enabled traits property for certain packages was essentially being overwritten to defaults rather than propagating what was calculated earlier due to how we were returning the
DependencyResolutionNodeduring the pub grub stage.This fix should now assure that we are passing the appropriate enabled traits to these nodes, and these traits are being considered when making calls to a
PackageContainer's dependency-related methods, assuring that we are considering transitively-enabled traits and the dependencies they may enable.