Expose platform-specific process file descriptors #101
+58
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jakepetroules
force-pushed
the
eng/PR-freebsd
branch
from
4e853c3 to
ad63fd6
Compare
jakepetroules
force-pushed
the
eng/PR-platform-handles
branch
from
eba918b to
e0559da
Compare
iCharlesHu
requested changes
Jul 4, 2025
jakepetroules
force-pushed
the
eng/PR-platform-handles
branch
from
e0559da to
e65a537
Compare
jakepetroules
changed the title
jakepetroules
force-pushed
the
eng/PR-platform-handles
branch
2 times, most recently
from
37a1e4e to
f500aa9
Compare
jakepetroules
force-pushed
the
eng/PR-platform-handles
branch
from
f500aa9 to
01f7f8e
Compare
Expose the pidfd on Linux and process/thread HANDLEs on Windows. This is necessary for interop with certain platform-native APIs, especially on Windows. pidfds are also gaining the ability to be used for more and more with each Linux kernel release. One test has been introduced which shows how this API could be used to associate a subprocess with a Job Object using the Windows API, and for Linux, a "test" that shows one use case for access to the raw fd, which is to read the globally unique (to the boot session) identifier for the process, allowing processes sharing the same PID to be distinguished. FreeBSD also has the concept of process file descriptors, and would expect to expose the same ProcessIdentifier API as for Linux. This may spread to other platforms in the future.
jakepetroules
force-pushed
the
eng/PR-platform-handles
branch
from
01f7f8e to
6191c80
Compare
iCharlesHu
approved these changes
Aug 11, 2025
| @@ -191,7 +191,7 @@ extension Configuration { | |||
| public struct ProcessIdentifier: Sendable, Hashable { | |||
| /// The platform specific process identifier value | |||
| public let value: pid_t | |||
| internal let processDescriptor: PlatformFileDescriptor | |||
| public let processDescriptor: CInt | |||
There was a problem hiding this comment.
nit: since we are using it else where might as well keep it here as well
There was a problem hiding this comment.
PlatformFileDescriptor is internal (just like ProcessIdentifierProtocol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the pidfd on Linux and process/thread HANDLEs on Windows. This is necessary for interop with certain platform-native APIs, especially on Windows. pidfds are also gaining the ability to be used for more and more with each Linux kernel release.
One test has been introduced which shows how this API could be used to associate a subprocess with a Job Object using the Windows API, and for Linux, a "test" that shows one use case for access to the raw fd, which is to read the globally unique (to the boot session) identifier for the process, allowing processes sharing the same PID to be distinguished.
FreeBSD also has the concept of process file descriptors, and would expect to expose the same ProcessIdentifier API as for Linux. This may spread to other platforms in the future.
--
Somewhat related article with some good info: https://gaultier.github.io/blog/way_too_many_ways_to_wait_for_a_child_process_with_a_timeout.html