Block the package from building on iOS-derived platforms #30
Conversation
|
@iCharlesHu Can I get an approval, please? |
itingliu
left a comment
itingliu
left a comment
There was a problem hiding this comment.
If we are to do this should we add an iOS CI (if possible at all)? Otherwise how would we know if a change causes the project to fail to build on iOS?
| error: Error, | ||
| errorPipe: CreatedPipe | ||
| ) throws -> Execution<Output, Error> { | ||
| #if !os(macOS) |
There was a problem hiding this comment.
The motivation of this change makes sense, but this runtime error inside this function is very non obvious to me.
|
Discussed offline: instead of allowing This is the same workaround we used in https://github.com/swiftlang/swift-corelibs-foundation/blob/873a14c644bf194a5dc961b925a626070a141706/Package.swift#L186 to signify that we do not build on iOS. |
Process spawning is not available there. Also remove a couple overly-specific platform conditions in tests that would be incorrect on other Unix-like platforms such as Android and FreeBSD.
|
OK, I've made those adjustments. |
jakepetroules
changed the title
5 participants
Process spawning is not available there. Also remove a couple overly-specific platform conditions in tests that would be incorrect on other Unix-like platforms such as Android and FreeBSD.