Skip to content

Conversation

beccadax
Copy link
Contributor

@beccadax beccadax commented Apr 26, 2025

Removes the experimental status of the syntax nodes for @abi, including a temporary hack used to make @abi parse correctly in macro expansion tests.

This will need to land at the same time as matching compiler changes in swiftlang/swift#81115.

Resolves rdar://150065196 (partially).

@beccadax
Copy link
Contributor Author

This PR is a draft pending approval of SE-0476.

@beccadax
Copy link
Contributor Author

@swift-ci please test

@beccadax beccadax marked this pull request as ready for review May 5, 2025 20:48
@beccadax beccadax requested review from ahoppen and bnbarham as code owners May 5, 2025 20:48
@beccadax
Copy link
Contributor Author

beccadax commented May 5, 2025

With swiftlang/swift#81115

@swift-ci please test

2 similar comments
@nkcsgexi
Copy link
Contributor

nkcsgexi commented May 7, 2025

With swiftlang/swift#81115

@swift-ci please test

@beccadax
Copy link
Contributor Author

beccadax commented May 7, 2025

With swiftlang/swift#81115

@swift-ci please test

@nkcsgexi
Copy link
Contributor

nkcsgexi commented May 7, 2025

@bnbarham Friendly ping about code owner review.

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bnbarham
Copy link
Contributor

bnbarham commented May 8, 2025

Checks all passed, we need to make some fixes to our PR workflow.

@bnbarham bnbarham merged commit c2eabd2 into swiftlang:main May 8, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants