Skip to content

[CMake] Remove unused dependency on Foundation build directory #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[CMake] Remove unused dependency on Foundation build directory #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions Sources/Overlays/_Testing_Foundation/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,6 @@ add_library(_Testing_Foundation
target_link_libraries(_Testing_Foundation PUBLIC
Testing)

# Although this library links Foundation on all platforms, it only does so using
# `target_link_libraries()` when building for non-Apple platforms. This is
# because that command uses the `-lFoundation` linker flag, but on Apple
# platforms Foundation is a .framework and requires a different flag. However,
# we don't need to explicitly pass any linker flag since it's handled
# automatically on Apple platforms via auto-linking.
if(NOT APPLE)
target_link_libraries(_Testing_Foundation PUBLIC
Foundation)
endif()

# Note: This does not enable Library Evolution, despite emitting a module
# interface, because Foundation does not have Library Evolution enabled for all
# platforms.
Expand Down
2 changes: 0 additions & 2 deletions Sources/Testing/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ if(NOT APPLE)
target_link_libraries(Testing PUBLIC
dispatch)
endif()
target_link_libraries(Testing PUBLIC
Foundation)
if (CMAKE_SYSTEM_NAME STREQUAL "FreeBSD")
target_link_libraries(Testing PUBLIC execinfo)
endif()
Expand Down