Adopt @abi in the standard library
#79937
Open
+524
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
force-pushed
the
abi-rewrote-your-history
branch
from
02b3318 to
ed8e82d
Compare
Merged
beccadax
force-pushed
the
abi-rewrote-your-history
branch
2 times, most recently
from
d0e20f3 to
fddc437
Compare
Merged
beccadax
force-pushed
the
abi-rewrote-your-history
branch
from
fddc437 to
b06f1be
Compare
beccadax
requested review from
a team,
CodaFi,
DougGregor,
ahoppen,
artemcm,
bnbarham,
hamishknight,
hborla,
jckarter,
ktoso,
rintaro,
slavapestov,
tshortli and
xedin
as code owners
beccadax
force-pushed
the
abi-rewrote-your-history
branch
from
b06f1be to
f93d4c0
Compare
|
@swift-ci please test |
Additional tests for the previous commit “Diagnose CustomAttrs as needed in `@abi`”.
Additional tests for the previous commit “[Legacy parser] No freestanding macros in `@abi`”.
beccadax
force-pushed
the
abi-rewrote-your-history
branch
from
f93d4c0 to
f0d0fcd
Compare
|
With swiftlang/swift-syntax#3062 @swift-ci please test |
This commit enables the ABIAttribute feature in the standard library build and replaces (nearly) every instance of `@_silgen_name(<mangled Swift name>)` in stdlib/public with an `@abi` attribute.
beccadax
force-pushed
the
abi-rewrote-your-history
branch
from
f0d0fcd to
6d29ef8
Compare
|
With swiftlang/swift-syntax#3062 @swift-ci please test |
ktoso
approved these changes
Apr 22, 2025
Azoy
reviewed
May 13, 2025
|
|
||
| @abi(func type<T, Metatype>(of _: T) -> Metatype) | ||
| @_spi(SwiftStdlibLegacyABI) @available(swift, obsoleted: 1) | ||
| @_silgen_name("$ss4type2ofq_x_tr0_lF") |
There was a problem hiding this comment.
I think I would prefer to just remove these symbols (in Builtin.swift) altogether since no one should be linking them in the first place.
Azoy
approved these changes
May 13, 2025
|
As a minor convenience, could we have a policy of using "throws" instead of "rethrows" inside the @abi annotations? This would make it slightly easier to find the remaining "rethrows" calls that need generalizing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces eligible uses of
@_silgen_nameinstdlib/with@abi. Because the API digester has a better understanding of@abithan@_silgen_name, this also affects the output of API digester tests run on the standard library; it should typically describe changes more accurately than it did before.This PR also includes two commits with macro-related tests that were originally part of #80383 but cannot be merged without a SwiftSyntax change (either swiftlang/swift-syntax#3026 or the changes that will be made if SE-0476 is accepted).
Standard library reviewers: Review the final commit; ignore the others. You might also want to search the standard library for uses of
@_silgen_namethat I might have missed. (Remember,@abiis not designed to replace uses of@_silgen_nameto assign an arbitrary string symbol, likeswift_stdlib_getDescription.)