-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[SE-0494][StdLib] Add isTriviallyIdentical(to:) Methods to Array, ArraySlice, and ContiguousArray
#82438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vanvoorden
wants to merge
8
commits into
swiftlang:main
Choose a base branch
from
vanvoorden:array-identical
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+320
−0
Open
[SE-0494][StdLib] Add isTriviallyIdentical(to:) Methods to Array, ArraySlice, and ContiguousArray
#82438
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c1a4725
[stdlib] array identical
vanvoorden 97af676
[stdlib] array identical
vanvoorden ec5b23e
[stdlib] array identical
vanvoorden 6d13a8f
[stdlib] array identical benchmarks
vanvoorden 9d15f14
Merge branch 'main' into array-identical
vanvoorden 2236650
[stdlib] array identical
vanvoorden 9fe77b4
Merge branch 'main' into array-identical
vanvoorden f5d33b2
[stdlib] array identical tests
vanvoorden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //===--- ArraySliceTests.swift --------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import TestsUtils | ||
|
|
||
| public let benchmarks = [ | ||
| BenchmarkInfo(name: "ArraySliceEqualUnique", runFunction: run_ArraySliceEqualUnique, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ArraySliceEqualShared", runFunction: run_ArraySliceEqualShared, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ArraySliceIdentical", runFunction: run_ArraySliceIdentical, tags: [.validation, .api, .Array]), | ||
| ] | ||
|
|
||
| @inline(never) | ||
| public func run_ArraySliceEqualUnique(_ n: Int) { | ||
| let a1 = ArraySlice(0 ..< n) | ||
| let a2 = ArraySlice(0 ..< n) | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ArraySliceEqualShared(_ n: Int) { | ||
| let a1 = ArraySlice(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ArraySliceIdentical(_ n: Int) { | ||
| let a1 = ArraySlice(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1.isTriviallyIdentical(to: a2)) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //===--- ArrayTests.swift -------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import TestsUtils | ||
|
|
||
| public let benchmarks = [ | ||
| BenchmarkInfo(name: "ArrayEqualUnique", runFunction: run_ArrayEqualUnique, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ArrayEqualShared", runFunction: run_ArrayEqualShared, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ArrayIdentical", runFunction: run_ArrayIdentical, tags: [.validation, .api, .Array]), | ||
| ] | ||
|
|
||
| @inline(never) | ||
| public func run_ArrayEqualUnique(_ n: Int) { | ||
| let a1 = Array(0 ..< n) | ||
| let a2 = Array(0 ..< n) | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ArrayEqualShared(_ n: Int) { | ||
| let a1 = Array(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ArrayIdentical(_ n: Int) { | ||
| let a1 = Array(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1.isTriviallyIdentical(to: a2)) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //===--- ContiguousArrayTests.swift ---------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import TestsUtils | ||
|
|
||
| public let benchmarks = [ | ||
| BenchmarkInfo(name: "ContiguousArrayEqualUnique", runFunction: run_ContiguousArrayEqualUnique, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ContiguousArrayEqualShared", runFunction: run_ContiguousArrayEqualShared, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ContiguousArrayIdentical", runFunction: run_ContiguousArrayIdentical, tags: [.validation, .api, .Array]), | ||
| ] | ||
|
|
||
| @inline(never) | ||
| public func run_ContiguousArrayEqualUnique(_ n: Int) { | ||
| let a1 = ContiguousArray(0 ..< n) | ||
| let a2 = ContiguousArray(0 ..< n) | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ContiguousArrayEqualShared(_ n: Int) { | ||
| let a1 = ContiguousArray(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ContiguousArrayIdentical(_ n: Int) { | ||
| let a1 = ContiguousArray(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1.isTriviallyIdentical(to: a2)) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lorentey Did we want to ship these opaque?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would prevent generic specialization, so the answer is no, sadly.