[Dependency Scanning] Reduce the amount of copying of collections of module IDs #83306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
cachemeifyoucan,
hborla,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci smoke test |
artemcm
force-pushed
the
NoMoreCopyAllDependencies
branch
from
24063b9 to
2d8a66c
Compare
Contributor
Author
|
@swift-ci smoke test |
artemcm
force-pushed
the
NoMoreCopyAllDependencies
branch
from
2d8a66c to
9e7816d
Compare
Contributor
Author
|
@swift-ci smoke test |
artemcm
force-pushed
the
NoMoreCopyAllDependencies
branch
from
9e7816d to
d4d58b9
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test windows platform |
artemcm
force-pushed
the
NoMoreCopyAllDependencies
branch
from
d4d58b9 to
39a0735
Compare
Contributor
Author
|
@swift-ci smoke test |
cachemeifyoucan
approved these changes
Jul 31, 2025
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test Windows platform |
artemcm
force-pushed
the
NoMoreCopyAllDependencies
branch
from
39a0735 to
a380103
Compare
Contributor
Author
|
@swift-ci smoke test |
artemcm
force-pushed
the
NoMoreCopyAllDependencies
branch
from
a380103 to
15bd9db
Compare
Contributor
Author
|
@swift-ci smoke test |
…module IDs Previously, frequently-used methods like 'getAllDependencies' and 'getAllClangDependencies' had to aggregate (copy) multiple collections stored in a 'ModuleDependencyInfo' into a new result array to present to the client. These methods have been refactored to instead return an iterable joined view of the constituent collections.
artemcm
force-pushed
the
NoMoreCopyAllDependencies
branch
from
15bd9db to
56a6c14
Compare
Contributor
Author
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, frequently-used methods like
getAllDependenciesandgetAllClangDependencieshad to aggregate (copy) multiple collections stored in aModuleDependencyInfointo a new result array to present to the client. These methods have been refactored to instead return an iterable joined view of the constituent collections. Once we can use C++20, we can instead adopt https://en.cppreference.com/w/cpp/ranges/join_view.html.