Skip to content

[Dependency Scanning] Reduce the amount of copying of collections of module IDs #83306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 24, 2025

Previously, frequently-used methods like getAllDependencies and getAllClangDependencies had to aggregate (copy) multiple collections stored in a ModuleDependencyInfo into a new result array to present to the client. These methods have been refactored to instead return an iterable joined view of the constituent collections. Once we can use C++20, we can instead adopt https://en.cppreference.com/w/cpp/ranges/join_view.html.

@artemcm
Copy link
Contributor Author

artemcm commented Jul 24, 2025

@swift-ci smoke test

@artemcm artemcm force-pushed the NoMoreCopyAllDependencies branch from 24063b9 to 2d8a66c Compare July 24, 2025 19:47
@artemcm
Copy link
Contributor Author

artemcm commented Jul 24, 2025

@swift-ci smoke test

@artemcm artemcm force-pushed the NoMoreCopyAllDependencies branch from 2d8a66c to 9e7816d Compare July 24, 2025 22:01
@artemcm
Copy link
Contributor Author

artemcm commented Jul 24, 2025

@swift-ci smoke test

@artemcm artemcm force-pushed the NoMoreCopyAllDependencies branch from 9e7816d to d4d58b9 Compare July 25, 2025 16:44
@artemcm
Copy link
Contributor Author

artemcm commented Jul 25, 2025

@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Jul 29, 2025

@swift-ci smoke test windows platform

artemcm added 2 commits July 31, 2025 10:42
…module IDs

Previously, frequently-used methods like 'getAllDependencies' and 'getAllClangDependencies' had to aggregate (copy) multiple collections stored in a 'ModuleDependencyInfo' into a new result array to present to the client. These methods have been refactored to instead return an iterable joined view of the constituent collections.
Apply clang-format to code in 'ModuleDependencies.h', 'ModuleDependencies.cpp', 'ModuleDependencyScanner.cpp'
@artemcm artemcm force-pushed the NoMoreCopyAllDependencies branch from d4d58b9 to 39a0735 Compare July 31, 2025 17:46
@artemcm
Copy link
Contributor Author

artemcm commented Jul 31, 2025

@swift-ci smoke test

@artemcm artemcm enabled auto-merge July 31, 2025 20:37
@artemcm
Copy link
Contributor Author

artemcm commented Aug 1, 2025

@swift-ci smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants