-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Dependency Scanning] Reduce the amount of copying of collections of module IDs #83306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
artemcm
wants to merge
2
commits into
swiftlang:main
Choose a base branch
from
artemcm:NoMoreCopyAllDependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+307
−245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci smoke test |
24063b9
to
2d8a66c
Compare
@swift-ci smoke test |
2d8a66c
to
9e7816d
Compare
@swift-ci smoke test |
9e7816d
to
d4d58b9
Compare
@swift-ci smoke test |
@swift-ci smoke test windows platform |
…module IDs Previously, frequently-used methods like 'getAllDependencies' and 'getAllClangDependencies' had to aggregate (copy) multiple collections stored in a 'ModuleDependencyInfo' into a new result array to present to the client. These methods have been refactored to instead return an iterable joined view of the constituent collections.
Apply clang-format to code in 'ModuleDependencies.h', 'ModuleDependencies.cpp', 'ModuleDependencyScanner.cpp'
d4d58b9
to
39a0735
Compare
@swift-ci smoke test |
cachemeifyoucan
approved these changes
Jul 31, 2025
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, frequently-used methods like
getAllDependencies
andgetAllClangDependencies
had to aggregate (copy) multiple collections stored in aModuleDependencyInfo
into a new result array to present to the client. These methods have been refactored to instead return an iterable joined view of the constituent collections. Once we can use C++20, we can instead adopt https://en.cppreference.com/w/cpp/ranges/join_view.html.