-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Overlay: add C++ interop libraries #83347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test |
@swift-ci please smoke test |
Please test with following PRs: @swift-ci please build toolchain Windows platform |
@swift-ci please smoke test macOS platform |
ab44174
to
61906d0
Compare
@swift-ci please smoke test windows platform |
@swift-ci please smoke test |
Please test with following PRs: @swift-ci please build toolchain Windows platform |
@swift-ci please smoke test |
@swift-ci please smoke test macOS platform |
@swift-ci please smoke test macOS platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reasonable to start landing the bulk of the logic -- asking for a few changes to not regress the existing Overlay build, and to allow vendors to enable this on their own schedule.
This introduces a build of the C++ interop runtime support to the new runtime library build.
@swift-ci please smoke test |
@swift-ci please test Windows platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, pending a minor change in how we set the default for SwiftOverlay_ENABLE_CXX_INTEROP
Co-authored-by: Eric Miotto <[email protected]>
@swift-ci please smoke test |
@swift-ci please smoke test macOS platform |
2 similar comments
@swift-ci please smoke test macOS platform |
@swift-ci please smoke test macOS platform |
if(NOT APPLE) | ||
add_subdirectory(cxxshim) | ||
endif() | ||
if(LINUX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually need to target a Linux that does not have a libstdc++, but uses libcxx instead. This assumption is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough - I think that we can iterate on that subsequently.
if(NOT APPLE) | ||
add_subdirectory(cxxshim) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem correct: CxxShim headers are used on all of the platforms, including Apple ones.
This introduces a build of the C++ interop runtime support to the new runtime library build.