Sema: Diagnose @dynamicMemberLookup subscripts that are not accessible enough
#83362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
tshortli
force-pushed
the
reject-inaccessible-dynamic-member-lookup-subscripts
branch
2 times, most recently
from
f86ae43 to
b4dac2b
Compare
tshortli
requested review from
eeckstein,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test macOS |
…ble enough. Since this is a source breaking change, downgrade the diagnostic to a warning until the next language version unless library evolution is enabled, in which case this would have resulted in a broken `.swiftinterface` and it therefore makes sense to diagnose eagerly. Resolves rdar://156919010.
tshortli
force-pushed
the
reject-inaccessible-dynamic-member-lookup-subscripts
branch
from
b4dac2b to
9302cbe
Compare
|
@swift-ci please smoke test |
tshortli
deleted the
reject-inaccessible-dynamic-member-lookup-subscripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a source breaking change, downgrade the diagnostic to a warning until the next language version unless library evolution is enabled, in which case this would have resulted in a broken
.swiftinterfaceand it therefore makes sense to diagnose eagerly.Resolves rdar://156919010.