[CSOptimizer] A narrow fix for nil coalescing operator optimization #83365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`??` is overloaded on optionality of the second parameter, prevent ranking the argument candidates for this parameter if there are candidates that come from failable initializer overloads because non-optional candidates are always going to be better and that can skew the selection. Resolves: rdar://156853018
|
@swift-ci please test |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jul 30, 2025
…tional injection This makes sure that optional and non-optional types are ranked uniformly when matched against a generic parameter type that could accept either of them. This is a more general fix for swiftlang#83365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
??is overloaded on optionality of the second parameter, prevent ranking the argument candidates for this parameter if there are candidates that come from failable initializer overloads because non-optional candidates are always going to be better and that can skew the selection.I think this should be handled by logic that checks whether generic parameter type is "unconstrained" but I'd need to look into modifying that for invertiable protocols.
Resolves: rdar://156853018