[Sema]: fix @discardableResult interaction with implicit @Sendable conversions #83475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
jamieQ
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
cc @xedin – lmk what you think if/when you have a chance please! |
…nversions Updates existing diagnostic handling to look through function conversions when suppressing diagnostics for unused functions that are return values from callees marked with @discardableResult.
jamieQ
force-pushed
the
fix-global-actor-discardable-result
branch
from
9adbc96 to
cd3e96a
Compare
|
@swift-ci please smoke test |
|
Merged, thanks for the fix and ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates existing diagnostic handling to look through function conversions when suppressing diagnostics for unused functions that are return values from callees marked with
@discardableResult.Resolves #83463