[Parse] Ignore '(' on newline after attribute names #83497
Conversation
rintaro
requested review from
hborla,
slavapestov,
xedin,
bnbarham,
CodaFi,
DougGregor and
hamishknight
as code owners
|
swiftlang/swift-syntax#3132 |
|
swiftlang/swift-syntax#3132 |
| @@ -2503,7 +2503,7 @@ static std::optional<Identifier> parseSingleAttrOptionImpl( | |||
| }; | |||
| bool isDeclModifier = DeclAttribute::isDeclModifier(DK); | |||
|
|
|||
| if (!P.Tok.is(tok::l_paren)) { | |||
| if (!P.Tok.isFollowingLParen()) { | |||
There was a problem hiding this comment.
Unrelated to this change but I've always disliked the name isFollowingLParen, to me it reads as "is token following an l-paren", when really it's "is token a following-l-paren". Maybe we should just call it isSameLineLParen?
Also '#error', '#warning', and '#sourceLocation'.
Other call-like syntax (call expression, macro expansion, and custom
attribtues) requires '(' on the same line as the callee. For consistency,
built-in attributes and built-in directives should also ignore '(' on
next line.
rintaro
force-pushed
the
parse-attr-l-paren-newline
branch
from
44ecb58 to
b271766
Compare
|
swiftlang/swift-syntax#3132 |
|
swiftlang/swift-syntax#3132 |
1 similar comment
|
swiftlang/swift-syntax#3132 |
|
swiftlang/swift-syntax#3132 |
|
swiftlang/swift-syntax#3132 |
|
swiftlang/swift-syntax#3132 |
|
swiftlang/swift-syntax#3132 |
2 similar comments
|
swiftlang/swift-syntax#3132 |
|
swiftlang/swift-syntax#3132 |
Also '#error', '#warning', and '#sourceLocation'.
Other call-like syntax (call expression, macro expansion, custom attributes, and some builtin attributes like
@available) requires '(' on the same line as the callee name. For consistency, all built-in attributes and directives should also ignore '(' on next line.