Optimizer: support statically initialized Atomic and Mutex globals
#83505
+436
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
kavon,
jckarter,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
eeckstein
requested review from
Azoy,
atrick,
meg-gupta and
nate-chandler
and removed request for
xedin,
slavapestov,
jckarter,
kavon and
hborla
Azoy
reviewed
Aug 2, 2025
| case let injectEnum as InjectEnumAddrInst: | ||
| if injectEnum.element.hasAssociatedValues { | ||
| if !injectEnum.operand.value.type.isLoadable(in: injectEnum.parentFunction) { | ||
| // TODO: we don't support non-loadable enum cases with payload yet, because IRGen support is missing. |
There was a problem hiding this comment.
What IRGen support is missing here?
There was a problem hiding this comment.
FixedTypeInfo (= used for non-loadable types) is missing the ability to pack a payload into an enum.
I added this in a comment.
|
It would also be nice to see if this patch allows statically initializing |
which allows e.g. eliminating dead `Atomic` values
…er` when generating a value constructor for an empty non-copyable type `zeroInitializer` is blocking optimizations. It is not needed because the constructor will initialize the memory anyway. We only need to tell mandatory passes that this memory should be treated as initialized.
…tType` in `Type`
…l.hasAssociatedValues`
eeckstein
force-pushed
the
non-loadable-global-inits
branch
from
763d3a4 to
6149e2e
Compare
… struct with `@_rawLayout` Even if the global declaration is a `let`. Raw-layout storage may be mutated even for let-variables. Treating such variables as non-let ensures that optimization don't assume that they are not mutated.
…ialized globals Just use the same method to create the zero initializer constant as in `emitBuiltinCall`.
…ut` types, like `Atomic`
Look through `@_rawLayout` projections, which "type casts" a raw-layout struct to it's content, which must match the like-type of the raw-layout, e.g.
```
@_rawLayout(like: T)
struct S {}
%2 = builtin "addressOfRawLayout"<S>(%1 : $*S) : $Builtin.RawPointer
%3 = pointer_to_address %2 to $*T
```
TODO: we don't support non-loadable enum cases with payload, yet, because IRGen support is missing.
eeckstein
force-pushed
the
non-loadable-global-inits
branch
from
6149e2e to
eaf38da
Compare
eeckstein
changed the title
Atomic globalsAtomic and Mutex globals
This is a good point and in fact there was missing a small thing to make this happen. I fixed it and added a test |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
This PR adds support for
@_rawLayoutstructs and non-loadable types in InitializeStaticGlobals.