[Dependency Scanning] Bridge Clang dependency scanner results on-demand #83600
+319
−349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
cachemeifyoucan,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hborla,
slavapestov,
xedin and
xymus
as code owners
|
@swift-ci smoke test |
artemcm
force-pushed
the
NoRedundantClangDepBridging
branch
from
f345188 to
4876b2f
Compare
|
@swift-ci smoke test |
Instead of always bridging all of the discovered modules of all of the queries, only do so for modules which are not already cached
artemcm
force-pushed
the
NoRedundantClangDepBridging
branch
from
4876b2f to
8cf2714
Compare
|
@swift-ci smoke test |
| clang::tooling::dependencies::ModuleOutputKind)>; | ||
|
|
||
| ModuleDependencyInfo | ||
| bridgeClangModuleDependency( |
There was a problem hiding this comment.
This can be a static method as implementation details.
Or maybe it can be a private method in DependencyScanner? The callbacks all have a capture of the scanner reference, which is probably fine since scanner should outlive everything but if the bridging callbacks are part of the scanner, then there is no need for callback or worry about lifetimes.
There was a problem hiding this comment.
This required a bigger refactor than it originally seemed, but I moved the bridging code into a private scanner utility.
…leDependencyScanner' utility This moves the functionality of 'bridgeClangModuleDependency' into a utility in the main scanner class because it relies on various objects whose lifetime is already tied to the scanner itself.
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83050 changed the behavior to query every Clang module identifier imported from Swift, even for modules which may have previously been discovered as transitive dependencies of another query. This means we now have a lot of results coming in from Clang scanner queries which are redundant, and we bridge them all, all of the time, which adds up to a substantial amount of time.
Instead of always bridging all of the discovered modules of all of the queries, only do so for modules which have not already been cached at the time we record query results.