Skip to content

NFC: use -Werror flags in CI only in asserts builds on Darwin #85336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

NFC: use -Werror flags in CI only in asserts builds on Darwin #85336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24fc955
Revert "NFC: use -Werror flags in all Darwin tests"
kavon Nov 5, 2025
7fa0a00
NFC: use -Werror flags in CI only in asserts builds on Darwin
kavon Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions utils/build-presets.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,11 +347,6 @@ skip-test-cmark

build-embedded-stdlib-cross-compiling

# Escalate certain C++ warnings to errors for Swift.
extra-swift-cmake-options=
-DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused -Werror=uninitialized -Werror=implicit-fallthrough"


[preset: buildbot_incremental_base_all_platforms]
mixin-preset=buildbot_incremental_base

Expand Down Expand Up @@ -684,6 +679,11 @@ skip-test-llbuild

enable-new-runtime-build

# Escalate certain C++ warnings to errors for Swift.
# NOTE: -Werror=unused is not yet working in non-asserts builds.
extra-swift-cmake-options=
-DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused -Werror=uninitialized -Werror=implicit-fallthrough"

[preset: buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto]
mixin-preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx
build-subdir=buildbot_incremental
Expand Down Expand Up @@ -1878,6 +1878,12 @@ skip-test-xros-host
# https://github.com/apple/swift-llbuild/issues/894
skip-test-llbuild

# Escalate certain C++ warnings to errors for Swift.
# NOTE: -Werror=unused is not yet working in non-asserts builds.
extra-swift-cmake-options=
-DSWIFT_EXTRA_CXX_FLAGS="-Werror=unused -Werror=uninitialized -Werror=implicit-fallthrough"


[preset: llvm_project_pull_request]
mixin-preset=buildbot_all_platforms,tools=RA,stdlib=RA

Expand Down