Extend @_extern to global and static variables #85370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow external declaration of global variables via `@_extern(c)`. Such variables need to have types represented in C (of course), have only storage (no accessors), and cannot have initializers. At the SIL level, we use the SIL asmname attribute to get the appropriate C name. While here, slightly shore up the `@_extern(c)` checking, which should fix issue swiftlang#70776 / rdar://153515764.
DougGregor
requested review from
AnthonyLatsis,
CodaFi,
bnbarham,
hamishknight,
hborla,
jckarter,
kavon,
rintaro,
rjmccall,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
Oops, failure was legit. Fix incoming. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow external declaration of global variables via
@_extern(c). Such variables need to have types represented in C (of course), have only storage (no accessors), and cannot have initializers. At the SIL level, we use the SIL asmname attribute to get the appropriate C name.While here, slightly shore up the
@_extern(c)checking, which should fix issue #70776 / rdar://153515764.